morpheus_network/driver/
virtio_blk.rs

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
//! VirtIO block device driver.
//!
//! Provides block I/O for ISO persistence via VirtIO-blk.
//!
//! # Architecture
//!
//! VirtIO-blk uses a single virtqueue for all I/O operations.
//! Each request is a 3-descriptor chain:
//!   1. Request header (16 bytes): type, reserved, sector
//!   2. Data buffer: read/write data
//!   3. Status byte: completion status
//!
//! # Reference
//! VirtIO Spec 1.2 §5.2, NETWORK_IMPL_GUIDE.md §6

use crate::driver::block_traits::{
    BlockCompletion, BlockDeviceInfo, BlockDriver, BlockDriverInit, BlockError,
};
use crate::driver::virtio::transport::{TransportType, VirtioTransport};
use crate::types::VirtqueueState;
use core::ptr;

// ═══════════════════════════════════════════════════════════════════════════
// ASM BINDINGS
// ═══════════════════════════════════════════════════════════════════════════

extern "win64" {
    fn asm_virtio_blk_read_capacity(mmio_base: u64) -> u64;
    fn asm_virtio_blk_read_blk_size(mmio_base: u64) -> u32;
    fn asm_virtio_blk_submit_read(
        vq: *mut VirtqueueState,
        sector: u64,
        data_buf_phys: u64,
        num_sectors: u64,
        header_buf_phys: u64,
        status_buf_phys: u64,
        desc_idx: u16,
    ) -> u32;
    fn asm_virtio_blk_submit_write(
        vq: *mut VirtqueueState,
        sector: u64,
        data_buf_phys: u64,
        num_sectors: u64,
        header_buf_phys: u64,
        status_buf_phys: u64,
        desc_idx: u16,
    ) -> u32;
    fn asm_virtio_blk_poll_complete(vq: *mut VirtqueueState, result: *mut BlkPollResult) -> u32;
    fn asm_virtio_blk_notify(vq: *mut VirtqueueState);
}

// Use existing VirtIO init functions
extern "win64" {
    fn asm_virtio_reset(mmio_base: u64) -> u32;
    fn asm_virtio_set_status(mmio_base: u64, status: u8);
    fn asm_virtio_get_status(mmio_base: u64) -> u8;
    fn asm_virtio_read_features(mmio_base: u64) -> u64;
    fn asm_virtio_write_features(mmio_base: u64, features: u64);
    fn asm_virtio_setup_queue(
        mmio_base: u64,
        queue_idx: u32,
        desc_phys: u64,
        avail_phys: u64,
        used_phys: u64,
        queue_size: u32,
    ) -> u32;
}

// ═══════════════════════════════════════════════════════════════════════════
// TYPES
// ═══════════════════════════════════════════════════════════════════════════

/// Result from asm_virtio_blk_poll_complete
#[repr(C)]
#[derive(Debug, Clone, Copy, Default)]
pub struct BlkPollResult {
    pub desc_idx: u16,
    pub status: u8,
    pub _pad: u8,
    pub bytes_written: u32,
}

/// VirtIO-blk request header (16 bytes).
#[repr(C)]
#[derive(Debug, Clone, Copy)]
pub struct VirtioBlkReqHeader {
    /// Request type: 0=read, 1=write, 4=flush
    pub req_type: u32,
    /// Reserved
    pub reserved: u32,
    /// Starting sector
    pub sector: u64,
}

impl VirtioBlkReqHeader {
    pub const TYPE_IN: u32 = 0; // Read
    pub const TYPE_OUT: u32 = 1; // Write
    pub const TYPE_FLUSH: u32 = 4;
}

/// Status codes
pub const VIRTIO_BLK_S_OK: u8 = 0;
pub const VIRTIO_BLK_S_IOERR: u8 = 1;
pub const VIRTIO_BLK_S_UNSUPP: u8 = 2;

/// VirtIO status bits
const VIRTIO_STATUS_ACKNOWLEDGE: u8 = 0x01;
const VIRTIO_STATUS_DRIVER: u8 = 0x02;
const VIRTIO_STATUS_FEATURES_OK: u8 = 0x08;
const VIRTIO_STATUS_DRIVER_OK: u8 = 0x04;
const VIRTIO_STATUS_FAILED: u8 = 0x80;

/// VirtIO-blk feature bits
const VIRTIO_F_VERSION_1: u64 = 1 << 32;
const VIRTIO_BLK_F_SIZE_MAX: u64 = 1 << 1;
const VIRTIO_BLK_F_SEG_MAX: u64 = 1 << 2;
const VIRTIO_BLK_F_BLK_SIZE: u64 = 1 << 6;
const VIRTIO_BLK_F_FLUSH: u64 = 1 << 9;
const VIRTIO_BLK_F_RO: u64 = 1 << 5;

/// Required features
const REQUIRED_FEATURES: u64 = VIRTIO_F_VERSION_1;

/// Desired features
const DESIRED_FEATURES: u64 = VIRTIO_BLK_F_BLK_SIZE | VIRTIO_BLK_F_FLUSH;

// ═══════════════════════════════════════════════════════════════════════════
// CONFIGURATION
// ═══════════════════════════════════════════════════════════════════════════

/// VirtIO-blk driver configuration.
#[derive(Debug, Clone)]
pub struct VirtioBlkConfig {
    /// Queue size (number of descriptors)
    pub queue_size: u16,
    /// Physical address of descriptor table
    pub desc_phys: u64,
    /// Physical address of available ring
    pub avail_phys: u64,
    /// Physical address of used ring
    pub used_phys: u64,
    /// Physical address of request headers (one per descriptor/3)
    pub headers_phys: u64,
    /// Physical address of status bytes (one per descriptor/3)
    pub status_phys: u64,
    /// CPU pointer to headers
    pub headers_cpu: u64,
    /// CPU pointer to status bytes
    pub status_cpu: u64,
    /// Physical address for notify MMIO (legacy) or computed from transport (PCI Modern)
    pub notify_addr: u64,
    /// Transport type: 0=MMIO, 1=PCI Modern
    pub transport_type: u8,
}

/// Initialization errors.
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum VirtioBlkInitError {
    /// Device reset failed
    ResetFailed,
    /// Feature negotiation failed
    FeatureNegotiationFailed,
    /// Queue setup failed
    QueueSetupFailed,
    /// Device reported failure
    DeviceFailed,
    /// Invalid configuration
    InvalidConfig,
    /// Transport error (from VirtioInitError)
    TransportError,
}

impl From<super::virtio::init::VirtioInitError> for VirtioBlkInitError {
    fn from(err: super::virtio::init::VirtioInitError) -> Self {
        use super::virtio::init::VirtioInitError;
        match err {
            VirtioInitError::ResetTimeout => VirtioBlkInitError::ResetFailed,
            VirtioInitError::FeatureNegotiationFailed => {
                VirtioBlkInitError::FeatureNegotiationFailed
            }
            VirtioInitError::FeaturesRejected => VirtioBlkInitError::FeatureNegotiationFailed,
            VirtioInitError::QueueSetupFailed => VirtioBlkInitError::QueueSetupFailed,
            VirtioInitError::RxPrefillFailed(_) => VirtioBlkInitError::QueueSetupFailed,
            VirtioInitError::DeviceError => VirtioBlkInitError::DeviceFailed,
        }
    }
}

// ═══════════════════════════════════════════════════════════════════════════
// REQUEST TRACKING
// ═══════════════════════════════════════════════════════════════════════════

/// Track in-flight request.
#[derive(Debug, Clone, Copy)]
struct InFlightRequest {
    /// Caller's request ID
    request_id: u32,
    /// First descriptor index (head of 3-chain)
    desc_idx: u16,
    /// Is this slot in use?
    active: bool,
}

impl Default for InFlightRequest {
    fn default() -> Self {
        Self {
            request_id: 0,
            desc_idx: 0,
            active: false,
        }
    }
}

// ═══════════════════════════════════════════════════════════════════════════
// DRIVER
// ═══════════════════════════════════════════════════════════════════════════

/// Maximum in-flight requests (queue_size / 3 since each request uses 3 descriptors)
const MAX_IN_FLIGHT: usize = 32;

/// VirtIO block device driver.
pub struct VirtioBlkDriver {
    /// MMIO base address (legacy) or common_cfg (PCI Modern)
    mmio_base: u64,
    /// Transport handle for device operations
    transport: VirtioTransport,
    /// Negotiated features
    features: u64,
    /// Device info
    info: BlockDeviceInfo,
    /// Virtqueue state
    queue: VirtqueueState,
    /// In-flight requests
    in_flight: [InFlightRequest; MAX_IN_FLIGHT],
    /// Next free descriptor set (each request uses 3)
    next_desc_set: u16,
    /// Headers CPU pointer
    headers_cpu: *mut VirtioBlkReqHeader,
    /// Status CPU pointer
    status_cpu: *mut u8,
}

impl VirtioBlkDriver {
    /// Create and initialize VirtIO-blk driver.
    ///
    /// # Safety
    /// - `mmio_base` must be valid VirtIO-blk MMIO address
    /// - `config` must contain valid physical addresses
    pub unsafe fn new(mmio_base: u64, config: VirtioBlkConfig) -> Result<Self, VirtioBlkInitError> {
        // Validate config
        if config.queue_size < 3 || config.queue_size > 256 {
            return Err(VirtioBlkInitError::InvalidConfig);
        }

        // ═══════════════════════════════════════════════════════════════════
        // STEP 1: Reset device
        // ═══════════════════════════════════════════════════════════════════
        asm_virtio_set_status(mmio_base, 0);

        // Wait for reset (simple spin - bounded)
        for _ in 0..1_000_000 {
            if asm_virtio_get_status(mmio_base) == 0 {
                break;
            }
            core::hint::spin_loop();
        }

        if asm_virtio_get_status(mmio_base) != 0 {
            return Err(VirtioBlkInitError::ResetFailed);
        }

        // ═══════════════════════════════════════════════════════════════════
        // STEP 2: Set ACKNOWLEDGE
        // ═══════════════════════════════════════════════════════════════════
        asm_virtio_set_status(mmio_base, VIRTIO_STATUS_ACKNOWLEDGE);

        // ═══════════════════════════════════════════════════════════════════
        // STEP 3: Set DRIVER
        // ═══════════════════════════════════════════════════════════════════
        asm_virtio_set_status(mmio_base, VIRTIO_STATUS_ACKNOWLEDGE | VIRTIO_STATUS_DRIVER);

        // ═══════════════════════════════════════════════════════════════════
        // STEP 4: Feature negotiation
        // ═══════════════════════════════════════════════════════════════════
        let device_features = asm_virtio_read_features(mmio_base);

        if device_features & REQUIRED_FEATURES != REQUIRED_FEATURES {
            asm_virtio_set_status(mmio_base, VIRTIO_STATUS_FAILED);
            return Err(VirtioBlkInitError::FeatureNegotiationFailed);
        }

        let our_features = REQUIRED_FEATURES | (DESIRED_FEATURES & device_features);
        asm_virtio_write_features(mmio_base, our_features);

        // ═══════════════════════════════════════════════════════════════════
        // STEP 5: Set FEATURES_OK
        // ═══════════════════════════════════════════════════════════════════
        asm_virtio_set_status(
            mmio_base,
            VIRTIO_STATUS_ACKNOWLEDGE | VIRTIO_STATUS_DRIVER | VIRTIO_STATUS_FEATURES_OK,
        );

        // Verify features accepted
        let status = asm_virtio_get_status(mmio_base);
        if status & VIRTIO_STATUS_FEATURES_OK == 0 {
            asm_virtio_set_status(mmio_base, VIRTIO_STATUS_FAILED);
            return Err(VirtioBlkInitError::FeatureNegotiationFailed);
        }

        // ═══════════════════════════════════════════════════════════════════
        // STEP 6: Setup virtqueue (queue 0)
        // ═══════════════════════════════════════════════════════════════════
        let result = asm_virtio_setup_queue(
            mmio_base,
            0, // queue index
            config.desc_phys,
            config.avail_phys,
            config.used_phys,
            config.queue_size as u32,
        );

        if result != 0 {
            asm_virtio_set_status(mmio_base, VIRTIO_STATUS_FAILED);
            return Err(VirtioBlkInitError::QueueSetupFailed);
        }

        // ═══════════════════════════════════════════════════════════════════
        // STEP 7: Set DRIVER_OK
        // ═══════════════════════════════════════════════════════════════════
        asm_virtio_set_status(
            mmio_base,
            VIRTIO_STATUS_ACKNOWLEDGE
                | VIRTIO_STATUS_DRIVER
                | VIRTIO_STATUS_FEATURES_OK
                | VIRTIO_STATUS_DRIVER_OK,
        );

        // ═══════════════════════════════════════════════════════════════════
        // STEP 8: Read device info
        // ═══════════════════════════════════════════════════════════════════
        let capacity = asm_virtio_blk_read_capacity(mmio_base);
        let sector_size = if our_features & VIRTIO_BLK_F_BLK_SIZE != 0 {
            asm_virtio_blk_read_blk_size(mmio_base)
        } else {
            512
        };
        let read_only = device_features & VIRTIO_BLK_F_RO != 0;

        let info = BlockDeviceInfo {
            total_sectors: capacity,
            sector_size,
            max_sectors_per_request: 128, // Conservative default
            read_only,
        };

        // Build queue state
        let queue = VirtqueueState {
            desc_base: config.desc_phys,
            avail_base: config.avail_phys,
            used_base: config.used_phys,
            queue_size: config.queue_size,
            queue_index: 0,
            _pad: 0,
            notify_addr: config.notify_addr,
            last_used_idx: 0,
            next_avail_idx: 0,
            _pad2: 0,
            desc_cpu_ptr: 0, // Not needed for blk
            buffer_cpu_base: 0,
            buffer_bus_base: 0,
            buffer_size: 0,
            buffer_count: 0,
        };

        Ok(Self {
            mmio_base,
            transport: VirtioTransport::mmio(mmio_base),
            features: our_features,
            info,
            queue,
            in_flight: [InFlightRequest::default(); MAX_IN_FLIGHT],
            next_desc_set: 0,
            headers_cpu: config.headers_cpu as *mut VirtioBlkReqHeader,
            status_cpu: config.status_cpu as *mut u8,
        })
    }

    /// Create and initialize VirtIO-blk driver using transport abstraction.
    ///
    /// This supports both MMIO (legacy) and PCI Modern transports.
    ///
    /// # Safety
    /// - Transport addresses must be valid
    /// - `config` must contain valid physical addresses
    pub unsafe fn new_with_transport(
        transport: VirtioTransport,
        config: VirtioBlkConfig,
        _tsc_freq: u64,
    ) -> Result<Self, VirtioBlkInitError> {
        // Validate config
        if config.queue_size < 3 || config.queue_size > 256 {
            return Err(VirtioBlkInitError::InvalidConfig);
        }

        let base = transport.base;

        // ═══════════════════════════════════════════════════════════════════
        // STEP 1: Reset device
        // ═══════════════════════════════════════════════════════════════════
        transport.set_status(0);

        // Wait for reset (simple spin - bounded)
        for _ in 0..1_000_000 {
            if transport.get_status() == 0 {
                break;
            }
            core::hint::spin_loop();
        }

        if transport.get_status() != 0 {
            return Err(VirtioBlkInitError::ResetFailed);
        }

        // ═══════════════════════════════════════════════════════════════════
        // STEP 2: Set ACKNOWLEDGE
        // ═══════════════════════════════════════════════════════════════════
        transport.set_status(VIRTIO_STATUS_ACKNOWLEDGE);

        // ═══════════════════════════════════════════════════════════════════
        // STEP 3: Set DRIVER
        // ═══════════════════════════════════════════════════════════════════
        transport.set_status(VIRTIO_STATUS_ACKNOWLEDGE | VIRTIO_STATUS_DRIVER);

        // ═══════════════════════════════════════════════════════════════════
        // STEP 4: Feature negotiation
        // ═══════════════════════════════════════════════════════════════════
        let device_features = transport.read_features();

        if device_features & REQUIRED_FEATURES != REQUIRED_FEATURES {
            transport.set_status(VIRTIO_STATUS_FAILED);
            return Err(VirtioBlkInitError::FeatureNegotiationFailed);
        }

        let our_features = REQUIRED_FEATURES | (DESIRED_FEATURES & device_features);
        transport.write_features(our_features);

        // ═══════════════════════════════════════════════════════════════════
        // STEP 5: Set FEATURES_OK
        // ═══════════════════════════════════════════════════════════════════
        transport.set_status(
            VIRTIO_STATUS_ACKNOWLEDGE | VIRTIO_STATUS_DRIVER | VIRTIO_STATUS_FEATURES_OK,
        );

        // Verify features accepted
        let status = transport.get_status();
        if status & VIRTIO_STATUS_FEATURES_OK == 0 {
            transport.set_status(VIRTIO_STATUS_FAILED);
            return Err(VirtioBlkInitError::FeatureNegotiationFailed);
        }

        // ═══════════════════════════════════════════════════════════════════
        // STEP 6: Setup virtqueue (queue 0)
        // ═══════════════════════════════════════════════════════════════════
        let notify_addr = transport.setup_queue(
            0, // queue index
            config.desc_phys,
            config.avail_phys,
            config.used_phys,
            config.queue_size,
        )?;

        // ═══════════════════════════════════════════════════════════════════
        // STEP 7: Set DRIVER_OK
        // ═══════════════════════════════════════════════════════════════════
        transport.set_status(
            VIRTIO_STATUS_ACKNOWLEDGE
                | VIRTIO_STATUS_DRIVER
                | VIRTIO_STATUS_FEATURES_OK
                | VIRTIO_STATUS_DRIVER_OK,
        );

        // ═══════════════════════════════════════════════════════════════════
        // STEP 8: Read device info
        // ═══════════════════════════════════════════════════════════════════
        let capacity = transport.read_blk_capacity();
        let sector_size = if our_features & VIRTIO_BLK_F_BLK_SIZE != 0 {
            transport.read_blk_size()
        } else {
            512
        };
        let read_only = device_features & VIRTIO_BLK_F_RO != 0;

        let info = BlockDeviceInfo {
            total_sectors: capacity,
            sector_size,
            max_sectors_per_request: 128, // Conservative default
            read_only,
        };

        // Build queue state
        let queue = VirtqueueState {
            desc_base: config.desc_phys,
            avail_base: config.avail_phys,
            used_base: config.used_phys,
            queue_size: config.queue_size,
            queue_index: 0,
            _pad: 0,
            notify_addr,
            last_used_idx: 0,
            next_avail_idx: 0,
            _pad2: 0,
            desc_cpu_ptr: 0, // Not needed for blk
            buffer_cpu_base: 0,
            buffer_bus_base: 0,
            buffer_size: 0,
            buffer_count: 0,
        };

        Ok(Self {
            mmio_base: base,
            transport,
            features: our_features,
            info,
            queue,
            in_flight: [InFlightRequest::default(); MAX_IN_FLIGHT],
            next_desc_set: 0,
            headers_cpu: config.headers_cpu as *mut VirtioBlkReqHeader,
            status_cpu: config.status_cpu as *mut u8,
        })
    }

    /// Allocate a descriptor set (3 consecutive descriptors).
    fn alloc_desc_set(&mut self) -> Option<(u16, u32)> {
        // Find free slot in in_flight
        for (slot_idx, slot) in self.in_flight.iter_mut().enumerate() {
            if !slot.active {
                let desc_idx = (slot_idx * 3) as u16;
                return Some((desc_idx, slot_idx as u32));
            }
        }
        None
    }

    /// Get header physical address for a descriptor set.
    fn header_phys(&self, slot_idx: usize) -> u64 {
        // Assuming headers are contiguous
        let base = self.headers_cpu as u64;
        base + (slot_idx * core::mem::size_of::<VirtioBlkReqHeader>()) as u64
    }

    /// Get status physical address for a descriptor set.
    fn status_phys(&self, slot_idx: usize) -> u64 {
        let base = self.status_cpu as u64;
        base + slot_idx as u64
    }

    /// Read status byte for a slot.
    fn read_status(&self, slot_idx: usize) -> u8 {
        unsafe { ptr::read_volatile(self.status_cpu.add(slot_idx)) }
    }
}

impl BlockDriver for VirtioBlkDriver {
    fn info(&self) -> BlockDeviceInfo {
        self.info
    }

    fn can_submit(&self) -> bool {
        // Check if we have a free descriptor set
        self.in_flight.iter().any(|s| !s.active)
    }

    fn submit_read(
        &mut self,
        sector: u64,
        buffer_phys: u64,
        num_sectors: u32,
        request_id: u32,
    ) -> Result<(), BlockError> {
        // Validate
        if sector + num_sectors as u64 > self.info.total_sectors {
            return Err(BlockError::InvalidSector);
        }

        // Allocate descriptor set
        let (desc_idx, slot_idx) = self.alloc_desc_set().ok_or(BlockError::QueueFull)?;

        // Write header
        let header = VirtioBlkReqHeader {
            req_type: VirtioBlkReqHeader::TYPE_IN,
            reserved: 0,
            sector,
        };
        unsafe {
            ptr::write_volatile(self.headers_cpu.add(slot_idx as usize), header);
        }

        // Initialize status
        unsafe {
            ptr::write_volatile(self.status_cpu.add(slot_idx as usize), 0xFF);
        }

        // Submit via ASM
        let result = unsafe {
            asm_virtio_blk_submit_read(
                &mut self.queue,
                sector,
                buffer_phys,
                num_sectors as u64,
                self.header_phys(slot_idx as usize),
                self.status_phys(slot_idx as usize),
                desc_idx,
            )
        };

        if result != 0 {
            return Err(BlockError::QueueFull);
        }

        // Track in-flight
        self.in_flight[slot_idx as usize] = InFlightRequest {
            request_id,
            desc_idx,
            active: true,
        };

        Ok(())
    }

    fn submit_write(
        &mut self,
        sector: u64,
        buffer_phys: u64,
        num_sectors: u32,
        request_id: u32,
    ) -> Result<(), BlockError> {
        // Check read-only
        if self.info.read_only {
            return Err(BlockError::ReadOnly);
        }

        // Validate
        if sector + num_sectors as u64 > self.info.total_sectors {
            return Err(BlockError::InvalidSector);
        }

        // Allocate descriptor set
        let (desc_idx, slot_idx) = self.alloc_desc_set().ok_or(BlockError::QueueFull)?;

        // Write header
        let header = VirtioBlkReqHeader {
            req_type: VirtioBlkReqHeader::TYPE_OUT,
            reserved: 0,
            sector,
        };
        unsafe {
            ptr::write_volatile(self.headers_cpu.add(slot_idx as usize), header);
        }

        // Initialize status
        unsafe {
            ptr::write_volatile(self.status_cpu.add(slot_idx as usize), 0xFF);
        }

        // Submit via ASM
        let result = unsafe {
            asm_virtio_blk_submit_write(
                &mut self.queue,
                sector,
                buffer_phys,
                num_sectors as u64,
                self.header_phys(slot_idx as usize),
                self.status_phys(slot_idx as usize),
                desc_idx,
            )
        };

        if result != 0 {
            return Err(BlockError::QueueFull);
        }

        // Track in-flight
        self.in_flight[slot_idx as usize] = InFlightRequest {
            request_id,
            desc_idx,
            active: true,
        };

        Ok(())
    }

    fn poll_completion(&mut self) -> Option<BlockCompletion> {
        let mut result = BlkPollResult::default();

        let has_completion = unsafe { asm_virtio_blk_poll_complete(&mut self.queue, &mut result) };

        if has_completion == 0 {
            return None;
        }

        // Find matching in-flight request
        let slot_idx = (result.desc_idx / 3) as usize;
        if slot_idx >= MAX_IN_FLIGHT {
            return None;
        }

        // Check if slot is active before doing anything
        if !self.in_flight[slot_idx].active {
            return None;
        }

        // Read status BEFORE taking mutable borrow of in_flight slot
        let status = self.read_status(slot_idx);

        // Now we can safely mutably borrow to extract info and clear
        let in_flight = &mut self.in_flight[slot_idx];
        let request_id = in_flight.request_id;

        // Mark slot as free
        in_flight.active = false;

        let completion = BlockCompletion {
            request_id,
            status,
            bytes_transferred: result.bytes_written,
        };

        Some(completion)
    }

    fn notify(&mut self) {
        unsafe {
            asm_virtio_blk_notify(&mut self.queue);
        }
    }

    fn flush(&mut self) -> Result<(), BlockError> {
        // VirtIO-blk flush requires a special 2-descriptor chain (header + status, no data).
        // Our ASM submit_write expects a 3-descriptor chain and doesn't handle 0-sector writes.
        // For now, return Ok() - writes are synchronous and QEMU will sync on exit.
        // TODO: Implement proper flush with dedicated ASM function for 2-descriptor chains.
        //
        // Note: Even without explicit flush, VirtIO-blk writes are durable once
        // the device returns completion status 0. The flush command is mainly
        // needed for volatile write caches which QEMU doesn't use by default.
        Ok(())
    }
}

impl BlockDriverInit for VirtioBlkDriver {
    type Error = VirtioBlkInitError;
    type Config = VirtioBlkConfig;

    fn supported_vendors() -> &'static [u16] {
        &[0x1AF4] // VirtIO vendor
    }

    fn supported_devices() -> &'static [u16] {
        &[0x1001, 0x1042] // virtio-blk legacy and modern
    }

    unsafe fn create(mmio_base: u64, config: Self::Config) -> Result<Self, Self::Error> {
        Self::new(mmio_base, config)
    }
}

// Safety: VirtioBlkDriver only contains raw pointers that are not shared
unsafe impl Send for VirtioBlkDriver {}